Fix CommonJS requires #85
|
@Jaymon, @jaridmargolin can this be merged? Can you add me as a contributor to GitHub/ NPM to merge PRs such as this one? |
@marksteve pls send a pull request to https://github.com/nerdyglasses/cakepan |
@nerdyglasses @gajus I just talked with @jaridmargolin, who has committed to adding some other maintainers to the repo by end of day today (December 6, 2016) |
Really? that would be awesome. I've just started copying over the changes. I've just pushed the commonjs changes to my repo. |
@gajus why the thumbs down? |
Please focus on supporting existing open-source effort (including liaising with project maintainers about making a release, becoming a contributor, etc) instead of forking a project and advertising it 7 hours later with a tagline:
|
it was dead for years until a few hours ago. i just need those pull request to go through. i will delete my repo once i can work with the existing one |
and i gave it a new name so it doesnt have to be formatter2.js on npm (sorry i'm on the phone. can't edit my comment above) |
Chances are the author will give you a contributor status. Don't have reputation? Look at the PRs by other authors. Find an author with a reputation. Offer to liaise on his behalf. Simple. |
I feel you. I just ask you to understand my point of view as well. there is a pr somewhere where people kept asking and there was no single sign of life. That being said. I'm looking forward to using this project instead of mine obviously and love & respect goes to all of you. |
@gajus @nerdyglasses I apologize for this situation, it's our fault. We moved away from this internally and we should've given more people commit access. I can be reached at jay@firstopinionapp.com if anyone needs to talk with me directly |
I have removed all my requests to send PRs to my repo and have changed the agrassive |
Hi @Jaymon, thank you for the brilliant project and for taking time to follow up. |
@nerdyglasses @gajus - Would like to make you both maintainers if you are interested. I think there would immense benefit in having some checks and balances before a PR is merged. Thank you for your willingness to contribute to the project. As @Jaymon stated, it is our fault for not passing the torch earlier. |
I am sorry, I am out of capacity at the moment to take on the torch. However, if you make me a contributor and someone pings me for a specific PR, I will be happy to review it. |
Funny enough, I am working on a project that does something very similar. :-) |
@jaridmargolin Braintree built Restricted Input which is a similar library. I don't think we'll be able to maintain this library, but thanks for the offer! |
@jaridmargolin sorry for the late response. I had a flu and didn't look here much. I'm not sure I can promise anything at this time because my time is very limited. |
No description provided.