/formatter.js

Linting fixes. #32

Merged
merged 1 commit into from Feb 28, 2014
+41 −37

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@brianpeiris @jaridmargolin
@brianpeiris
Contributor
brianpeiris commented Jan 28, 2014

I've fixed some linting issues that were caught by our closure compiler setup. The code used char as a variable in several places. This caused an error since it's considered a reserved word in EcmaScript 3. I also fixed an undeclared variable and a missing semicolon.
Lastly, I added some options to the grunt config so that these types of errors can be caught going forward. I also added the concatenated files to the list of linted files since you can't lint the concatenation templates on their own.
@brianpeiris brianpeiris referenced this pull request Jan 28, 2014
Merged

CI Additions #33

@jaridmargolin jaridmargolin merged commit a83973b into firstopinion:master Feb 28, 2014
1 check passed

1 check passed

default The Travis CI build passed
Details
@jaridmargolin
Owner
jaridmargolin commented Feb 28, 2014

Appreciate the PR! Apologies for the delayed response.
@jaridmargolin jaridmargolin added a commit that referenced this pull request Feb 28, 2014
@jaridmargolin jaridmargolin Merge fixes from number #32 & #33 470d7bb
@brianpeiris
Contributor
brianpeiris commented Feb 28, 2014

No worries. Thanks for accepting the PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment