/formatter.js

Reuse the current pattern as default on 'resetPattern ' call #31

Merged
merged 2 commits into from Feb 28, 2014
+1 −0

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

2 participants

@fabdouglas @jaridmargolin
@fabdouglas
Contributor
fabdouglas commented Jan 27, 2014

Make optional the pattern during the call of 'resetPattern'.
@jaridmargolin
Owner
jaridmargolin commented Feb 28, 2014

Much appreciated on the PR and apologies for the delayed response. This looks great. Would love to see a test implemented.

https://github.com/firstopinion/formatter.js/blob/master/test/formatter.js#L289
@fabdouglas fabdouglas added a commit to fabdouglas/formatter.js that referenced this pull request Feb 28, 2014
@fabdouglas fabdouglas Test for PR #31 
Test for PR #31 as requested.
 257c49d
@fabdouglas fabdouglas added a commit to fabdouglas/formatter.js that referenced this pull request Feb 28, 2014
@fabdouglas fabdouglas Test for PR #31 
Test for PR #31 as requested.
 7c97881
@fabdouglas fabdouglas added a commit to fabdouglas/formatter.js that referenced this pull request Feb 28, 2014
@fabdouglas fabdouglas Test for PR #31 
Test for PR #31 as requested.
 e2e8c2b
@fabdouglas fabdouglas added a commit to fabdouglas/formatter.js that referenced this pull request Feb 28, 2014
@fabdouglas fabdouglas Test for PR #31 
Test for PR #31 as requested.
 269e8a9
@fabdouglas fabdouglas referenced this pull request Feb 28, 2014
Merged

Test for PR #31 #35

@jaridmargolin jaridmargolin merged commit 571ee93 into firstopinion:master Feb 28, 2014
1 check passed

1 check passed

default The Travis CI build passed
Details
@fabdouglas fabdouglas deleted the fabdouglas:patch-2 branch Mar 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment