/dropdown.js

jquery.dropdown.js #30

Merged
merged 2 commits into from Nov 13, 2015

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@arielbottero @FezVrasta
@arielbottero
Contributor
arielbottero commented Oct 31, 2015

Highlight the current selection

if($target[0].tagName.toUpperCase()=="LI") {selectOptions.not($target).removeClass("selected"); } // at line 298
$option.addClass("selected"); // at line 351
@arielbottero arielbottero jquery.dropdown.js 
Highlighted the current selection

if($target[0].tagName.toUpperCase()=="LI") {selectOptions.not($target).removeClass("selected"); } // at line 298
$option.addClass("selected"); // at line 351
 dec4fba
@FezVrasta FezVrasta commented on an outdated diff Nov 2, 2015
jquery.dropdown.js
@@ -295,7 +295,7 @@
// Behavior for single select
if (!multi) {
// Unselect options except the one that will be selected
- selectOptions.not($target).removeClass("selected");
+ if($target[0].tagName.toUpperCase()=="LI") {selectOptions.not($target).removeClass("selected"); }
FezVrasta
FezVrasta Nov 2, 2015 Owner 
if ($target.is("li")) {
  selectOptions.not($target).removeClass("selected");
}
@FezVrasta FezVrasta commented on an outdated diff Nov 2, 2015
jquery.dropdown.js
@@ -349,6 +349,7 @@
// Ss it selected?
if ($this.prop("selected")) {
$option.attr("selected", true);
+ $option.addClass("selected");
FezVrasta
FezVrasta Nov 2, 2015 Owner

The indentation is wrong here :(
@FezVrasta FezVrasta merged commit 9d36644 into FezVrasta:master Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment